Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to PyYAML 6.0.1 #1508

Merged
merged 6 commits into from
Jul 19, 2023
Merged

Upgrade to PyYAML 6.0.1 #1508

merged 6 commits into from
Jul 19, 2023

Conversation

jdeanwallace
Copy link
Contributor

@jdeanwallace jdeanwallace commented Jul 18, 2023 •
edited
Loading

Resolves #1507

The release of Cython 3 broke PyYAML 5.4. This PR upgrades to PyYAML 6.0.1 which pins Cython < 3.0.0.

Notes

  1. While bootstrapping the molecule testing environment, it was complaining about the following dependency conflict: 
    The conflict is caused by:
    The user requested PyYAML==6.0.1
    molecule 3.2.3 depends on PyYAML<6 and >=5.1
    So based on someone's suggestion from the original GitHub issue, I pinned pyyaml to version 5.3.1. However, I only did this for the molecule dependencies.

Review on CodeApprove

@jdeanwallace jdeanwallace marked this pull request as ready for review July 18, 2023 13:11
@jdeanwallace CodeApprove
Copy link
Contributor Author

Automated comment from CodeApprove ➜

⏳ @mtlynch please review this Pull Request

mtlynch
mtlynch approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@mtlynch mtlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated comment from CodeApprove ➜

Approved on CodeApprove
✔️ Approved

LGTM, thanks!

👀 @jdeanwallace it's your turn please take a look

@jdeanwallace jdeanwallace merged commit ec45ba7 into master Jul 19, 2023
@jdeanwallace jdeanwallace deleted the pyyaml-6.0.1 branch July 19, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtlynch mtlynch mtlynch approved these changes

Assignees
No one assigned
Labels
codeapprove
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build error with PyYAML 5.4.1
2 participants
@jdeanwallace @mtlynch